On Mon, 3 Mar 2025 14:11:09 GMT, Albert Mingkun Yang <[email protected]> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * fix comment (trailing whitespace)
>> * another assert when snapshotting at a safepoint.
>
> src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp line 143:
>
>> 141:
>> 142: __ bind(is_clean_card);
>> 143: // Card was not clean. Dirty card and go to next..
>
> Why "not clean"? I thought this path is for dirtying clean card?
My interpretation is: in this path the card has been found clean ("is clean")
earlier. So dirty it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1977733993
