On Mon, 3 Mar 2025 18:50:37 GMT, Ivan Walulya <[email protected]> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * fix comment (trailing whitespace)
>> * another assert when snapshotting at a safepoint.
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp line 84:
>
>> 82: // Tracks the current refinement state from idle to completion (and
>> reset back
>> 83: // to idle).
>> 84: class G1ConcurrentRefineWorkState {
>
> G1ConcurrentRefinementState? I am not convinced the "Work" adds any clarity
We agreed on `G1ConcurrentRefineSweepState` for now, better suggestions welcome.
Use `Refine` instead of `Refinement` since all pre-existing classes also use
`Refine`. This could be renamed in an extra change.
> src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp line 113:
>
>> 111: // Current epoch the work has been started; used to determine if
>> there has been
>> 112: // a forced card table swap due to a garbage collection while doing
>> work.
>> 113: size_t _refine_work_epoch;
>
> same as previous comment, why `refine_work` instead of `refinement`?
Already renamed, same as previous comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1979050867
PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1979051649
