On Tue, 4 Mar 2025 09:52:40 GMT, Thomas Schatzl <[email protected]> wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentRefine.hpp line 84:
>>
>>> 82: // Tracks the current refinement state from idle to completion (and
>>> reset back
>>> 83: // to idle).
>>> 84: class G1ConcurrentRefineWorkState {
>>
>> G1ConcurrentRefinementState? I am not convinced the "Work" adds any clarity
>
> We agreed on `G1ConcurrentRefineSweepState` for now, better suggestions
> welcome.
>
> Use `Refine` instead of `Refinement` since all pre-existing classes also use
> `Refine`. This could be renamed in an extra change.
Add the `Sweep` in the name because this is not the state for entire refinement
(which also includes information about when to start refinement/sweeping).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1979053344
