On Sun, 16 Mar 2025 16:50:19 GMT, Luca Kellermann <d...@openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 246 commits: >> >> - Merge branch 'master' into implement-jep502 >> - Clean up exception messages and fix comments >> - Rename field >> - Rename method and fix comment >> - Rework reenterant logic >> - Use acquire semantics for reading rather than volatile semantics >> - Add missing null check >> - Simplify handling of sentinel, wrap, and unwrap >> - Fix JavaDoc issues >> - Fix members in StableEnumFunction >> - ... and 236 more: https://git.openjdk.org/jdk/compare/4e51a8c9...d6e1573f > > src/java.base/share/classes/java/util/ImmutableCollections.java line 798: > >> 796: throw new IndexOutOfBoundsException(i); >> 797: } >> 798: } > > I think `orElseSet` should be outside of the `try` block, otherwise an > `ArrayIndexOutOfBoundsException` thrown by `mapper.apply` will be wrapped. Even better, we should just do a `Preconditions.checkIndex` explicitly. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r1997792857
