On Mon, 17 Mar 2025 00:44:39 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Per Minborg has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 246 commits: >> >> - Merge branch 'master' into implement-jep502 >> - Clean up exception messages and fix comments >> - Rename field >> - Rename method and fix comment >> - Rework reenterant logic >> - Use acquire semantics for reading rather than volatile semantics >> - Add missing null check >> - Simplify handling of sentinel, wrap, and unwrap >> - Fix JavaDoc issues >> - Fix members in StableEnumFunction >> - ... and 236 more: https://git.openjdk.org/jdk/compare/4e51a8c9...d6e1573f > > src/java.base/share/classes/jdk/internal/lang/stable/StableValueFactories.java > line 71: > >> 69: } >> 70: >> 71: public static <K, T> Map<K, StableValueImpl<T>> map(Set<K> keys) { > > I recommend choosing a different name from `map(Set, Function)` for > navigation simplicitiy. Can you expand on the comment? Why would another name simplify navigation? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23972#discussion_r2020570880
