On Tue, 25 Mar 2025 13:33:15 GMT, Alan Bateman <[email protected]> wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed apiNote and implNote from CharBuffer, as suggested by Chen
>
> src/java.base/share/classes/java/lang/CharSequence.java line 307:
>
>> 305: /**
>> 306: * Characters are copied from this sequence into the
>> 307: * destination character array {@code dst}. The first character to
>
> I think the "Characters are copied ..." sentence goes back to StringBuffer in
> JDK 1.0. CS doesn't need to copy this exactly and I think better to say that
> it copies chars from this sequence into the given destination array.
Do you like this more: `Copies chars from this sequence into the given
destination array.` ?
> src/java.base/share/classes/java/lang/CharSequence.java line 335:
>
>> 333: *
>> 334: * @implSpec
>> 335: * The default implementation iterates over {@link #charAt(int)}.
>
> This sentence doesn't make sense, did something get deleted?
Do you like this more: `The default implementation invokes {@link #charAt(int)}
in a loop.`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2013947462
PR Review Comment: https://git.openjdk.org/jdk/pull/21730#discussion_r2013944760
