On Wed, 2 Apr 2025 15:23:54 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing test.
>
> src/jdk.jshell/share/classes/jdk/internal/jshell/tool/Startup.java line 340:
>
>> 338: */
>> 339: static Startup defaultStartup(int sourceLevel, boolean preview,
>> MessageHandler mh) {
>> 340: boolean startup24 = sourceLevel < 25;
>
> should we use a constant here?
Yes, there should be a constant. Done here:
https://github.com/openjdk/jdk/pull/23801/commits/d66703c1cb4f9f532f9a98181b598fa45e55ef73
Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23801#discussion_r2025240134
