On Wed, 9 Apr 2025 17:52:26 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review feedback - avoiding hardcoded constants.
>
> src/java.base/share/classes/jdk/internal/module/ModuleInfo.java line 415:
>
>> 413: if (major >= 54
>> 414: && mods.contains(Requires.Modifier.STATIC)) {
>> 415: String flagName = "ACC_STATIC_PHASE";
>
> A minor comment on the style here, do you mind combin L413+414 as it will
> make it easier to read. The change is okay of course.
I did this:
https://github.com/openjdk/jdk/pull/23801/commits/029e0dd59c7160f4fe043dd7191860b067ca787c
Please let me know if something more/different is needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23801#discussion_r2037978491
