On Wed, 9 Apr 2025 10:36:03 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review v2 > > make/modules/jdk.jlink/Java.gmk line 28: > >> 26: >> ################################################################################ >> 27: >> 28: COPY += upgrade_files_java.base > > Any chance you can give this file a different name? It looks like it has > extension `.base`. Maybe `upgrade_files_java.base.txt`, and then we can have > a more general pattern of `*.txt`? Or maybe it should really be a properties > file, to clearly indicate the nature of the file? Sure. It's not really a properties file (which assumes `key=value`). How about `upgrade_files_<module>.conf`? Then the pattern could be `upgrade_files_*.conf`. Thoughts? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24388#discussion_r2035181858
