On Wed, 9 Apr 2025 11:38:25 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> make/modules/jdk.jlink/Java.gmk line 28: >> >>> 26: >>> ################################################################################ >>> 27: >>> 28: COPY += upgrade_files_java.base >> >> Any chance you can give this file a different name? It looks like it has >> extension `.base`. Maybe `upgrade_files_java.base.txt`, and then we can have >> a more general pattern of `*.txt`? Or maybe it should really be a properties >> file, to clearly indicate the nature of the file? > > Sure. It's not really a properties file (which assumes `key=value`). How > about `upgrade_files_<module>.conf`? Then the pattern could be > `upgrade_files_*.conf`. Thoughts? Yeah, my comment was meant more like "maybe you should turn it into a proper properties file, by introducing a key name". But maybe that's just silly and overkill. `.conf` sounds fine, I guess. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24388#discussion_r2035187744
