On Tue, 8 Apr 2025 22:55:53 GMT, Brent Christian <bchri...@openjdk.org> wrote:

>> test/lib/jdk/test/whitebox/WhiteBox.java line 569:
>> 
>>> 567:    * This method should usually be called after a call to 
>>> WhiteBox.fullGC().
>>> 568:    */
>>> 569:   public static void waitForReferenceProcessing() {
>> 
>> Can the code duplication be avoided?
>
> That would be nice.
> A primary goal here is to not disrupt existing tests that use `WhiteBox` or 
> `ForceGC`, (e.g. by necessitating additional tags, `@run` arguments, etc).
> I don't think there's a way for `WhiteBox.java` and `ForceGC.java` to both 
> refer to code at some shared location without tests having to add a new tag - 
> `@build`, I think.
> However I will look into it a bit further.

(No code duplication if just adding to WhiteBox.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24527#discussion_r2036049957

Reply via email to