On Thu, 10 Apr 2025 22:18:20 GMT, Brent Christian <[email protected]> wrote:
>> test/lib/jdk/test/whitebox/WhiteBox.java line 570:
>>
>>> 568: * This method should usually be called after a call to
>>> WhiteBox.fullGC().
>>> 569: */
>>> 570: public static void waitForReferenceProcessing() {
>>
>> Reference::waitForReferenceProcessing throws InterruptedException. Probably
>> this should be similarly
>> declared.
>
> I disagree. IMO, for a test library, it's an unnecessary burden to make
> callers catch a checked exception.
Hm. In general, if something blocks interruptibly, it should be declared to
throw InterruptedException instead of catching and rethrowing something of
another exception type. We should look at the use sites to be sure, but it's
generally not an inconvenience for tests to deal with checked exceptions; it's
perfectly acceptable for them to declare `throws InterruptedException` or even
`throws Exception` and let the framework handle the exception if the test
itself doesn't want to.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24527#discussion_r2038705048
