On Mon, 21 Apr 2025 10:05:21 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Code simplification > > src/java.base/share/classes/java/math/MutableBigInteger.java line 1924: > >> 1922: * @implNote The implementation is based on the material in Henry >> S. Warren, >> 1923: * Jr., <i>Hacker's Delight (2nd ed.)</i> (Addison Wesley, 2013), >> 279-282. >> 1924: * > > * @implNote The implementation is based on the material in Henry S. Warren, > * Jr., <i>Hacker's Delight (2nd ed.)</i> (Addison Wesley, 2013), 279-282. > * > > I'm looking at this reference, and I only see integer square root here. But > this is n >= 3. > > I do see an explanation at [nth > root](https://en.wikipedia.org/wiki/Nth_root#Computing_principal_roots) I have put a proof of the recurrence in the description of the PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24690#discussion_r2052298673
