On Tue, 22 Apr 2025 09:05:09 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

> Can I please get a review of this test only change which proposes to improve 
> the debuggability of `com/sun/jndi/ldap/LdapPoolTimeoutTest.java`?
> 
> This test has been failing intermittently in our CI for several years. 
> Detailed are noted in https://bugs.openjdk.org/browse/JDK-8287062. Most of 
> these failures are because the exception message, in an exception that was 
> raised, contains an unexpected value (apparently `null`). The test doesn't 
> propagate the unexpected exception, thus it's not clear why the exception 
> message is different than what the test expects. The commit in this PR 
> propagates the original exception if the message is unexpected. This should 
> help identify the underlying cause of the test failure, if/when it fails the 
> next time.
> 
> I have run this test with these changes and the test continues to pass.

Also, this is a nitpick, but still. There are quite a few unused imports in the 
file. Could you please remove them? :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24793#issuecomment-2820927318

Reply via email to