On Tue, 22 Apr 2025 10:43:45 GMT, Mikhail Yankelevich <myankelev...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Mikhail's review - print the task number that failed >> - remove unused imports from the test > > test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java line 109: > >> 107: } catch (ExecutionException e) { >> 108: failedCount++; >> 109: System.err.println("test failure:"); > > Do you think giving each test failure a number or at least printing the > `failedCount` might be beneficial for debugging? This way it would be easier > to know if the error is happening exclusively on the first/ after the first/ > last run. > So the message in the `System.err` looked something like this: > > Run 2 - failure 1 - error: > <Error stack trace> Hello Mikhail, that's a good point to print the task number that failed. I've now updated the PR to include that detail in the `System.err` message. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24793#discussion_r2053882350