On Mon, 28 Apr 2025 19:56:23 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix iterator missing NSEE
>
> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 634:
>
>> 632: * <p>
>> 633: * This method may return {@code 0} if the structure does not
>> exist in
>> 634: * the given {@code cffv}.
>
> Suggestion:
>
> * {@return the union of masks of all access flags defined for
> * this location in the given class file format version}
> * <p>
> * This method returns {@code 0} if there are no access flags in
> * the given {@code cffv}.
>
> The word structure seems out of place and indefinite.
I meant "if this location is not present in the given `cffv`" and don't think
"no access flags" is the best way to phrase it - consider MODULE location for
Java 8.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23095#discussion_r2064460386
