On Wed, 30 Apr 2025 13:14:28 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 21 additional >> commits since the last revision: >> >> - Eirik's review about code comments >> - fix comment typo >> - merge latest from master branch >> - 8355975: introduce a test for 8355975 >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - merge latest from master branch >> - improve code comment for ZipFile.zipCoder >> - ... and 11 more: https://git.openjdk.org/jdk/compare/dad821f7...9a29b960 > > test/jdk/java/util/zip/ZipFile/ZipFileCharsetTest.java line 59: > >> 57: * A ZipFile can be constructed by passing a Charset which will be >> used to >> 58: * decode the entry names (and comment) in a ZIP file. >> 59: * The test here verifies that when multiple ZipFile instances are > > Minor nit > > 'The test here verifies' -> "The test verifies' Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23986#discussion_r2068751644
