On Thu, 1 May 2025 01:15:26 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> > I think throwing the SkippedException is the right way to go long term but > > I assume this shows as a reported failure in Mach5 and in the case of > > assumeTrue it does not result in a failure being reported? > > That is correct, use of assumeTrue will skip the test (which is what we want) > but it will be classified as aborted instead of skipped. Throwing > jtreg.SkippedException however fails that test which isn't a good thing. So I think it is important that the reporting is addressed WRT SkippedException, especially in light of some of the discussions raised in previous threads for Mach5. So in order to keep the Mach5 pipeline happy, I see the options is simply returning or use assumeTrue providing this does not create any additional reporting noise. It might be worthwhile creating a follow on bug to address this in the test, linking to the JtREG bug so that it does not get lost/forgotten ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23986#discussion_r2070240224
