On Thu, 1 May 2025 09:04:00 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve on comments
>
> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 81:
>
>> 79: @Override
>> 80: public int hashCode() {
>> 81: return System.identityHashCode(this);
>
> What's the value in these overloads? Isn't this implementation the same we'd
> get if there were no overrides?
Ugh - it's a record, I see. Which brings up the question -- should it be a
record? Should it advertize its `size and `tl` components (they seem rather
implementation specific?).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24829#discussion_r2070017489
