On Thu, 1 May 2025 09:51:41 GMT, Tatsunori Uchino <d...@openjdk.org> wrote:

>> Anyway you need to merge master first to test `stdin.encoding`.
>
> `stdin.encoding` seems to work as intended in Windows for Japanese. (I 
> managed to get the Windows binary of my PR) No need to change. (I wish the 
> constructors of `InputStreamReader` and `Scanner` used `stdin.encoding` 
> instead of UTF-8 for `System.in` by defaultI) Sorry to have bothered you.

Hello @tats-u , there is no bother, I appreciate you looking at this.

The addition of `stdin.encoding` in 
[JDK-8350703](https://bugs.openjdk.org/browse/JDK-8350703) (#24738) happened 
very quickly. I worked with @naotoj and @AlanBateman on it and we think it does 
the right thing, but there are many Windows configurations that we don't have 
the opportunity to test, so more feedback is helpful.

Initially it would be good to understand if `stdin.encoding` is specified and 
implemented correctly, and whether it provides the right behavior for 
`java.lang.IO` in JEP 512.

In the future we can consider additional uses of `stdin.encoding` in other 
parts of the JDK.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24438#discussion_r2070508985

Reply via email to