On Fri, 9 May 2025 15:39:35 GMT, Andrew Haley <a...@openjdk.org> wrote:

>> This intrinsic is generally faster than the current implementation for 
>> Panama segment operations for all writes larger than about 8 bytes in size, 
>> increasing to more than 2* the performance on larger memory blocks on 
>> Graviton 2, between "panama" (C2 generated, what we use now) and "unsafe" 
>> (this intrinsic).
>> 
>> 
>> Benchmark                       (aligned)  (size)  Mode  Cnt     Score    
>> Error  Units
>> MemorySegmentFillUnsafe.panama       true  262143  avgt   10  7295.638 ±  
>> 0.422  ns/op
>> MemorySegmentFillUnsafe.panama      false  262143  avgt   10  8345.300 ± 
>> 80.161  ns/op
>> MemorySegmentFillUnsafe.unsafe       true  262143  avgt   10  2930.594 ±  
>> 0.180  ns/op
>> MemorySegmentFillUnsafe.unsafe      false  262143  avgt   10  3136.828 ±  
>> 0.232  ns/op
>
> Andrew Haley has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   generate_unsafecopy_common_error_exit

Changes requested by syan (Committer).

test/micro/org/openjdk/bench/java/lang/foreign/MemorySegmentFillUnsafe.java 
line 2:

> 1: /*
> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

2025 maybe more suitable

-------------

PR Review: https://git.openjdk.org/jdk/pull/25147#pullrequestreview-2831415179
PR Review Comment: https://git.openjdk.org/jdk/pull/25147#discussion_r2083540891

Reply via email to