On Mon, 12 May 2025 09:18:13 GMT, Andrew Dinn <ad...@openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> generate_unsafecopy_common_error_exit > > src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 2611: > >> 2609: >> 2610: __ subs(count, count, 64); >> 2611: __ add(dest, dest, 64); > > This add could be elided by employing a post-increment on dest in each of the > two writes above, saving on code size. Is there a reason to prefer the add? Yes, there is. A post-increment is often an extra cycle. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25147#discussion_r2084252981
