On Tue, 6 May 2025 15:43:07 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8354724: Revert BufferedReader; simplify Reader changes removing 
> overridable self-call; update test

For the APIs then both methods will need to specify what they return when 
already at end of stream, does readAllAsString return an empty or null, does 
readAllLines return an empty list?  

Also, you look at the paragraph that we put in InputStream.readAllBytes to 
cover the case where the reader is asynchronously closed or the thread 
interrupted while blocked reading the remaining characters?  There is also 
wording about the I/O error case that I think can come over too as it is more 
complete than what is in the current PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24728#issuecomment-2871020072

Reply via email to