On Mon, 12 May 2025 10:30:31 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> This PR proposes to add a safety net around closing the executor. >> Apparently, in some rare configuration, the VT is not run/notified correctly. >> >> Not completing the test for such a configuration is unlikely to mask >> potential issues that this test is supposed to reveal. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Rework solution test/jdk/java/foreign/TestBufferStackStress2.java line 27: > 25: * @test > 26: * > 27: * If the VM does not have continuations, then no VTs can ever be > scheduled Nit - jtreg allows for a `@comment` tag in the test definition https://openjdk.org/jtreg/tag-spec.html. It would be good to prefix this line with `@comment`. test/jdk/java/foreign/TestBufferStackStress2.java line 48: > 46: import java.util.concurrent.Executors; > 47: import java.util.concurrent.ForkJoinWorkerThread; > 48: import java.util.concurrent.TimeUnit; Likely no longer needed? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25177#discussion_r2084398966 PR Review Comment: https://git.openjdk.org/jdk/pull/25177#discussion_r2084401253
