On Tue, 13 May 2025 13:48:32 GMT, Jaikiran Pai <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment based on current behaviour.
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 174:
>
>> 172: }
>> 173: default -> {
>> 174: }
>
> Since we don't allow for any other value, I think moving the `throw new
> IllegalArgumentException` from outside of the switch into this `default` case
> might be suitable.
I rewrote to avoid the switch now there's no way it needs to cope with being
the enum value.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2091660167
