On Thu, 15 May 2025 17:30:35 GMT, David Beaumont <d...@openjdk.org> wrote:
>> I created JDK-8356888 yesterday and [bplb](https://github.com/bplb) has >> picked it up already. > > So does this mean the code is good as-is now? Hello David, yes it's fine to throw `IllegalArgumentException` from here. The specification of `FileSystemProvider.newFileSystem(...)` APIs will be updated in a separate PR to specify the `IllegalArgumentException` that gets thrown. With that, the zipfs provider implementation will conform to the specification and applications are then expected to deal with the `IllegalArgumentException` caused by an incorrect environment property value that was passed during the filesystem construction. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2091688623