On Wed, 14 May 2025 18:23:09 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> Vicente Romero has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 34 commits: >> >> - Merge branch 'master' into JDK-8354556 >> - Update src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java >> >> Co-authored-by: Chen Liang <li...@openjdk.org> >> - additional changes from Archie >> - removing dead code >> - integrating code from Archie >> - fixing bugs, removing dead code >> - additional documentation changes and bug fixes >> - documentation and adding alias to lint categories >> - Merge branch 'master' into JDK-8354556 >> - addressing review comment >> - ... and 24 more: https://git.openjdk.org/jdk/compare/e7ce661a...22acaf29 > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java line 2673: > >> 2671: result = check(tree, capturedRes, KindSelector.VAL, >> resultInfo); >> 2672: } >> 2673: if (env.info.lint.isEnabled(LintCategory.IDENTITY)) { > > This is the only place where there's a check whether the lint is enabled > before the call to `checkRequiresIdentity`. Is there a reason for that? left over of the initial approach I guess. I will remove it ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24746#discussion_r2091837488
