On Thu, 15 May 2025 22:32:12 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or constructor parameter will be an >> object with a unique identity, not an instance of a value-based class; or >> that the type argument to a given type parameter will not be a value-based >> class type. >> >> For more details please refer to the complete description in the >> corresponding JIRA entry [1] >> >> TIA >> >> [1] https://bugs.openjdk.org/browse/JDK-8354556 > > Vicente Romero has updated the pull request incrementally with one additional > commit since the last revision: > > addressing review comments javac changes look good to me, with one trivial nit in `Check`. src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 5848: > 5846: } > 5847: } > 5848: } Nit - there appears to be an extra space at the beginning of this line. ------------- Marked as reviewed by jlahoda (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24746#pullrequestreview-2849882159 PR Review Comment: https://git.openjdk.org/jdk/pull/24746#discussion_r2095145360
