On Wed, 14 May 2025 18:27:18 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> Vicente Romero has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 34 commits: >> >> - Merge branch 'master' into JDK-8354556 >> - Update src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java >> >> Co-authored-by: Chen Liang <li...@openjdk.org> >> - additional changes from Archie >> - removing dead code >> - integrating code from Archie >> - fixing bugs, removing dead code >> - additional documentation changes and bug fixes >> - documentation and adding alias to lint categories >> - Merge branch 'master' into JDK-8354556 >> - addressing review comment >> - ... and 24 more: https://git.openjdk.org/jdk/compare/e7ce661a...22acaf29 > > src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java line 5823: > >> 5821: SymbolMetadata sm = t.tsym.getMetadata(); >> 5822: if (sm != null && !t.getTypeArguments().isEmpty()) { >> 5823: for (Attribute.TypeCompound ta: >> sm.getTypeAttributes().stream() > > The code here, and the code in `checkIfTypeParamsRequiresIdentity` look > similar a lot (although they manipulate `List<Type>` and > `List<JCExpression>`, of course. I wonder if there's a chance to share the > code, at least partially. I have rewritten both using streams, technically we could still reuse some code but not a big deal, dunno ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24746#discussion_r2092053355
