On Mon, 19 May 2025 15:03:51 GMT, Raffaello Giulietti <[email protected]>
wrote:
>> src/java.base/share/classes/java/math/BigInteger.java line 5034:
>>
>>> 5032: */
>>> 5033: private byte[] magSerializedForm() {
>>> 5034: byte[] result = new byte[(magBitLength() + 7) >>> 3];
>>
>> I think there's a risk of overflow, so consider
>> Suggestion:
>>
>> byte[] result = new byte[(magBitLength() - 1 >>> 3) + 1];
>
> Ah no, there's a unsigned shift `>>>`.
> Disregard
Indeed, I had thought about this possibility too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25166#discussion_r2095957646
