On Tue, 3 Jun 2025 05:48:30 GMT, SendaoYan <s...@openjdk.org> wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use of OutputAnalyzer.shouldHaveExitValue() where appropriate > > test/jdk/java/io/Console/StdoutEncodingTest.java line 41: > >> 39: * Console.charset() method. "expect" command in Windows/Cygwin >> 40: * does not work as expected. Ignoring tests on Windows. >> 41: * @requires (os.family == "linux") | (os.family == "mac") > > The previous line say `Ignoring tests on Windows.`, so this line maybe set as > > > @requires os.family != "windows"
It is true that the intention is to exclude testing on Windows. However, I would like to keep the testing on the platforms which are guaranteed to work, as the test relies on the behavior of the platforms' executable. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25601#discussion_r2124449337
