On Tue, 3 Jun 2025 16:59:18 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Fixing a regression caused by the fix to JDK-8356985. Although the fix in >> `CharsetTest` was a clean-up and not the gist of the original issue, the >> change seem to have caused not finding `SkippedException` at runtime in >> certain cases. Changing the test to JUnit based so that the offending >> `SkippedException` can be replaced with JUnit's `Assumptions`. Also renamed >> the test case itself to reflect what's actually tested in it. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Use of OutputAnalyzer.shouldHaveExitValue() where appropriate Swapping the `jtreg.SkippedException` with `Assumptions` looks good, and we would expect no problems since _StdinEncodingTest.java_ has been passing with a similar `Assumptions` set up. LGTM. ------------- Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/25601#pullrequestreview-2893422288
