On Mon, 9 Jun 2025 20:42:43 GMT, Justin Lu <j...@openjdk.org> wrote:

> Please review this PR which finishes Applet removal for the test: 
> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
> 
> `testclasses.jar` is updated such that the two classes no longer extend 
> Applet.
> 
> 
> $ javap fo\ o.class 
> public class fo o {
> }
> $ javap æ$'\302\211'$'\302\213'å$'\302\206'$'\302\214'.class 
> public class 手册 {
> }
> 
> 
> The bug description of 
> [JDK-8358729](https://bugs.openjdk.org/browse/JDK-8358729) contains the 
> original `javap` output for those classes.
> 
> Additionally, the security APIs that were marked for removal are also removed 
> from this test as well.

Hello Justin, how was the class file with those space characters in the method 
name and the class name generated? If we can do that within the test itself 
then I think it should also allow us to generate that JAR file dynamically in 
the test instead of having to continue maintaining this binary file.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25703#issuecomment-2963398242

Reply via email to