On Thu, 14 Aug 2025 10:34:59 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of these change which removes the outdated use of > `jdk.internal.javac.ParticipatesInPreview` and the qualified export of > `jdk.internal.javac` package? This addresses > https://bugs.openjdk.org/browse/JDK-8365533. > > These qualified exports in `java.base` were added in > https://bugs.openjdk.org/browse/JDK-8308753 when ClassFile API was in > preview. Starting Java 24, ClassFile API is now a part of Java SE. These > affected modules don't use any other preview feature, so there's no longer a > need to export the `jdk.internal.javac` package to these modules. > > tier1, tier2 and tier3 testing of this change completed without any related > failures. > See also #26765 ([JDK‑8365416](https://bugs.openjdk.org/browse/JDK-8365416)) Right, that's what prompted me to start looking into this. The java.desktop change for which that other PR is open can go ahead independently. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26776#issuecomment-3188258941
