On Mon, 18 Aug 2025 04:49:28 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Can I please get a review of these change which removes the outdated use of >> `jdk.internal.javac.ParticipatesInPreview` and the qualified export of >> `jdk.internal.javac` package? This addresses >> https://bugs.openjdk.org/browse/JDK-8365533. >> >> These qualified exports in `java.base` were added in >> https://bugs.openjdk.org/browse/JDK-8308753 when ClassFile API was in >> preview. Starting Java 24, ClassFile API is now a part of Java SE. These >> affected modules don't use any other preview feature, so there's no longer a >> need to export the `jdk.internal.javac` package to these modules. >> >> tier1, tier2 and tier3 testing of this change completed without any related >> failures. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - merge latest from master branch > - 8365533: Remove outdated jdk.internal.javac package export to several > modules from java.base Marked as reviewed by alanb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26776#pullrequestreview-3126883742
