On Fri, 29 Aug 2025 23:59:54 GMT, Justin Lu <j...@openjdk.org> wrote:

> This PR addresses a JCK test failure of an unexpected SIOOBE during 
> DecimalFormat parsing. During the char by char comparison in `matchAffix`, 
> the minimum of the length of the parsed String and the PP index + affix 
> length are iterated on. The parse position index needs to be checked to not 
> be negative to ensure that we do not index the String below 0. Taking the 
> minimum of those two previously mentioned values already guarantees that we 
> do not index the String above the length.

Would it be possible to review the DecimalFormat tests in the jdk repo? I'm 
wondering if the changes for lenient parsing in JDK-8363972 should have had 
more tests (it's good that tests elsewhere found the issue but it does suggest 
that we don't have enough tests in the jdk repo).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27014#issuecomment-3239007000

Reply via email to