On Tue, 2 Sep 2025 17:01:58 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Missing the bug ID in the new test
>> - Adding additional tests and moving tests to PositionTest
>
> test/jdk/java/text/Format/NumberFormat/LenientParseTest.java line 172:
>
>> 170: assertNull(assertDoesNotThrow(() -> new
>> DecimalFormat().parse("1", new ParsePosition(-1))));
>> 171: }
>> 172:
>
> Thanks for writing the invalid case test. As Alan suggested, maybe we could
> provide more edge case tests.
Added some additional tests with a focus on affix matching, specifically
ensuring SIOOBE does not leak out in any of those cases. i.e. The bounds checks
should ensure `false` is returned for those cases. But specifically for the
failing JCK test, the main test we need on the JDK repo side is a negative
ParsePosition index test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27014#discussion_r2317281582
