On Mon, 13 Oct 2025 21:12:40 GMT, Pavel Rappo <[email protected]> wrote:
>> We recently [discussed] the possibility of introducing saturating arithmetic >> for deadline computation. Consider this PR as a starting point. Once we >> agree on the implementation, I'll file a CSR. >> >> I created a method in `Instant` to add `Duration`. One could argue that the >> proper way would be to go all the way and create a method in `Temporal` to >> add `TemporalAmount`. Or maybe even expand the functionality, and create an >> additional method in `Temporal` to subtract `TemporalAmount`. >> >> My current thinking is that if we were to do that, there would be a lot of >> expensive, unused code. Saturating logic seems to be only useful for >> `Instant` and `Duration`. >> >> Even if we decide to extend `Temporal` to add/subtract `TemporalAmount`, it >> could always be done later. From the perspective of `Instant`, >> `plus(TemporalAmount)` will be just an overload of `plus(Duration)`. >> >> [discussed]: >> https://mail.openjdk.org/pipermail/core-libs-dev/2025-September/151098.html > > Pavel Rappo has updated the pull request incrementally with four additional > commits since the last revision: > > - Simplify impl > - Clarify spec > - Revert "Add Instant.minusSaturating(Duration)" > > This reverts commit 35537856f1759c7abbe2b5c5bbb267a90612f729. > - Add test for null > /reviewers 2 reviewer Don't worry, it had already been like that for some time :-) https://github.com/openjdk/jdk/pull/27549#issuecomment-3374476578 ------------- PR Comment: https://git.openjdk.org/jdk/pull/27549#issuecomment-3407377180
