On Mon, 27 Oct 2025 02:10:05 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing >> of streams and ensuring the termination of the process is the responsibility >> of the caller. The `Process.close()` method provides a clear and obvious way >> to ensure all the streams are closed and the process terminated. >> >> The try-with-resources statement is frequently used to open streams and >> ensure they are closed on exiting the block. By implementing >> `AutoClosable.close()` the completeness of closing the streams and process >> termination can be done by try-with-resources. >> >> The actions of the `close()` method are to close each stream and destroy the >> process if it has not terminated. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Corrected ProcessCloseTest to expect a racy result from "echo abc" and > Process.close. The recent test updates have addressed the GHA test failures on windows and the dashboards are clear. Thanks you for all the reviews, a couple of re-reviews are needed to have the PR marked ready for integration. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26649#issuecomment-3451952287
