On Mon, 27 Oct 2025 02:10:05 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>> to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and
>> ensure they are closed on exiting the block. By implementing
>> `AutoClosable.close()` the completeness of closing the streams and process
>> termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the
>> process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected ProcessCloseTest to expect a racy result from "echo abc" and
> Process.close.
src/java.base/share/classes/java/lang/Process.java line 212:
> 210: * The {@code outputWriter} and {@code outputStream} to the process
> are closed.
> 211: * The {@code inputReader} and {@code inputStream} from the process
> are closed.
> 212: * The {@code errorReader} and {@code errorStream} from the process
> are closed.
The implSpec is quite verbose as it lists all 6 streams and character streams.
Maybe shorten to say that the method first closes all I/O streams, then waits
for the process to terminate?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2466405551
