On Mon, 27 Oct 2025 18:42:32 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>> to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and
>> ensure they are closed on exiting the block. By implementing
>> `AutoClosable.close()` the completeness of closing the streams and process
>> termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the
>> process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add \@implNote to recommend overriding close and calling `super.close()`.
src/java.base/share/classes/java/lang/snippet-files/ProcessExamples.java line
31:
> 29: public class ProcessExamples {
> 30: // @start region=example
> 31: void example() {
Should there be another version of this that is involved with interruption set
at top of method? That example would forever freeze which shows there is a
problem with the example.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2476178801
