On Mon, 27 Oct 2025 18:42:32 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>> to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and
>> ensure they are closed on exiting the block. By implementing
>> `AutoClosable.close()` the completeness of closing the streams and process
>> termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the
>> process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add \@implNote to recommend overriding close and calling `super.close()`.
Minor nit formatting suggestions. Otherwise the specification and
implementation of the `close()` method look reasonable to me.
src/java.base/share/classes/java/lang/Process.java line 199:
> 197: * <p>
> 198: * After the streams are closed this method {@linkplain #waitFor()
> waits for} the
> 199: * process to terminate. If interrupted while {@linkplain #waitFor
> waiting} for termination
Suggestion:
* process to terminate. If interrupted while {@linkplain #waitFor()
waiting} for termination
src/java.base/share/classes/java/lang/Process.java line 218:
> 216: * The {@code errorReader} and {@code errorStream} from the process
> are closed.
> 217: * This method {@linkplain #waitFor() waits for the process} to
> terminate.
> 218: * If {@linkplain #waitFor() waitFor()} is {@linkplain
> Thread#interrupt() interrupted}
Suggestion:
* If {@link #waitFor() waitFor()} is {@linkplain Thread#interrupt()
interrupted}
-------------
PR Review: https://git.openjdk.org/jdk/pull/26649#pullrequestreview-3400131750
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2478469017
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2478477773
