On Wed, 26 Nov 2025 03:24:30 GMT, Alexander Matveev <[email protected]>
wrote:
>> Added following tests:
>> - Verify mac app store PKG doesn't have scripts (added to
>> `PkgScriptsTest.java`).
>> - `--launcher-as-service` ignored for mac app store PKG (added to
>> `ServiceTest.java`).
>> - `--launcher-as-service` for additional launcher ignored for mac app store
>> PKG (added to `ServiceTest.java`).
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8351095: [macos] Add more jpackage tests for --mac-app-store option [v3]
test/jdk/tools/jpackage/share/ServiceTest.java line 267:
> 265: if (isMacAppStore) {
> 266: cmd.addArgument("--mac-app-store");
> 267: }
Do we still need this change?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28487#discussion_r2562898582
