On Wed, 26 Nov 2025 03:24:30 GMT, Alexander Matveev <[email protected]> 
wrote:

>> Added following tests:
>> - Verify mac app store PKG doesn't have scripts (added to 
>> `PkgScriptsTest.java`).
>> - `--launcher-as-service` ignored for mac app store PKG  (added to 
>> `ServiceTest.java`).
>> - `--launcher-as-service` for additional launcher ignored for mac app store 
>> PKG (added to `ServiceTest.java`).
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8351095: [macos] Add more jpackage tests for --mac-app-store option [v3]

8351095: [macos] Add more jpackage tests for --mac-app-store option [v4]
- Removed unnecessary "--mac-app-store" when creating PKG from predefined app 
image.
- Fixed `cmdlineBooleanOption()` to return `Optional.empty()` is boolean option 
is not found, so `findAppProperty()` falls back to app image to find option 
value.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28487#issuecomment-3583769864

Reply via email to