On Fri, 12 Dec 2025 23:35:29 GMT, Weijun Wang <[email protected]> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert Chinese preview change
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties
> line 1637:
>
>> 1635: # 0: symbol, 1: file object
>> 1636: # lint: classfile
>> 1637: compiler.warn.inconsistent.inner.classes={1} 中 {0} 的 InnerClasses
>> 属性与源代码不一致\n（可能需要使用 {0} 重新编译 {1}）
>
> I am a little unsure of this. The English value has "({1} may need to be
> recompiled with {0})", which can be interpreted as "compiling 1 along with 0"
> but the Chinese translation sounds like "compiling 1 using 0". I tried to
> find where this is used but cannot.
@liach Do you happen to know what the intent is here? I see you have reviewed
this area before and I would appreciate the review.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28802#discussion_r2620503781
