On Sat, 20 Dec 2025 08:23:25 GMT, eunbin son <[email protected]> wrote:
>> ## Summary >> Adds comprehensive edge case tests for `Objects.requireNonNull`, >> `requireNonNullElse`, and `requireNonNullElseGet` methods to improve >> test coverage. >> >> ## Problem >> The current test suite for `Objects.requireNonNull` methods covers >> basic cases but lacks edge case coverage. >> >> ## Solution >> This PR adds tests for the following edge cases: >> - requireNonNull with null Supplier parameter >> - requireNonNull with Supplier that throws exception >> - requireNonNullElse with both arguments null >> - requireNonNullElseGet with null supplier >> - requireNonNullElseGet with supplier returning null >> >> ## Issue >> Fixes JDK-8373661 >> >> **JBS Issue Link**: >> https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8373661 >> >> ## Type of Change >> - [x] Test addition/modification >> - [ ] Bug fix >> - [ ] New feature >> - [ ] Documentation improvement >> - [ ] Refactoring >> >> ## Testing >> >> make test TEST="jtreg:test/jdk/java/util/Objects" > > eunbin son has updated the pull request incrementally with one additional > commit since the last revision: > > 8373661: Address liach's feedback on copyright year and redundant messages > > I apologize for the earlier incorrect implementation. As @liach noted, > "I asked to run a command to fix the copyright year and to remove > redundant message, both of which are done incorrectly." I have now > properly addressed both concerns: > > - Copyright year: Updated to 2025 (the copyright year was already set > in the previous commit, but I should have used the > update_copyright_year.sh script as requested) > > - Redundant messages: Removed all exception message tests, verbose > inline comments, and simplified all test messages to use only test > method names > > Thanks to @liach for the detailed feedback. So much time and power extended on reviewing a PR for one test file whose update changes essentially nothing to the JDK... Using AI tools on the JDK for no other purpose than using AI... There are other priorities imho. This PR should be closed for lack of relevance. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28845#issuecomment-3679738015
