> Please review this PR which migrates the java.time tests from TestNG to > JUnit. The java.time tests use TestNG based on the directory level settings > configured by TEST.properties, so they are best migrated altogether. This is > a large PR, so I have tried to make the changes clear by commit. > > First, the auto conversion tool is run in > https://github.com/openjdk/jdk/commit/b1fd7dbdec85aac5a44cc875e57a36be8f1b6974. > https://github.com/openjdk/jdk/commit/3805cfd8765c0c76b61893dcf1670951402f98c3 > and > https://github.com/openjdk/jdk/commit/b697ca5d9a8067bcecea2dfb32f92f7699085dee > are required so that the tests can actually compile and run. > https://github.com/openjdk/jdk/commit/d07c912c4c16d2b3307e489563f148f71cfdf4a4 > addresses the timeout annotation which was not covered by the auto > conversion tool. > The rest of the commits are aesthetic related. > > Before conversion stats > > > Test results: passed: 187 > Framework-based tests: 32,339 = 32,339 TestNG + 0 JUnit > > > After conversion stats > > > Test results: passed: 187 > Framework-based tests: 32,339 = 0 TestNG + 32,339 JUnit
Justin Lu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision: - Removing now outdated testNG comment - Merge branch 'master' into java.time-to-JUnit - Merge branch 'master' into java.time-to-JUnit - nontestng -> nonjunit - Fix comments - Fixing @timeout as well as unrelated stray spacing - Apply copyright years - Cleaning up some leftover whitespace from tool - Automated conversion created statement lambdas for exception tests. Modify to expression lambdas - Cleaning up unused JUnit imports - ... and 3 more: https://git.openjdk.org/jdk/compare/c6f3f85a...1cb313ea ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28911/files - new: https://git.openjdk.org/jdk/pull/28911/files/d90d23ed..1cb313ea Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28911&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28911&range=01-02 Stats: 8409 lines in 2284 files changed: 2778 ins; 1646 del; 3985 mod Patch: https://git.openjdk.org/jdk/pull/28911.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28911/head:pull/28911 PR: https://git.openjdk.org/jdk/pull/28911
