On Wed, 26 Nov 2025 16:46:41 GMT, David Beaumont <[email protected]> wrote:
>> Adds a semantic reason for failure which can be optionally interrogated by >> calling code. >> Use the 'Reason.BAD_VERSION' value to trigger a different translated error >> message from the JImageTask. >> >> I would consider moving the error message string into the Reason enum to >> simplify the code triggering the error and avoid message string duplication, >> but it's not straightforward due to the need to supply the version numbers. >> >> We can use this approach to provide translated messages for all the distinct >> failure reasons if needed. > > David Beaumont has updated the pull request incrementally with two additional > commits since the last revision: > > - Redo bad indentation > - undo blank line What you're suggesting is closer to my original change. See what I undid in: https://github.com/openjdk/jdk/pull/28456/changes/aa40f0c711cf5c02a243bda01d2e2d40d4b2b352 ------------- PR Comment: https://git.openjdk.org/jdk/pull/28456#issuecomment-3741049157
