On Wed, 14 Jan 2026 23:00:29 GMT, Alexander Matveev <[email protected]> wrote:
>> Alexey Semenyuk has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains 12 new commits since the last revision: >> >> - Update copyright year >> - InOutPathTest: remove tests cases for non-existent paths specified for >> --app-content and --mac-dmg-content options; AppContentTest: add a test case >> for --app-content set to the output app image >> - FileUtils: remove redundant functionality >> - Add and integrate RootedPath >> - AppContentTest: don't verify app image if jpackage is expected to fail >> - Support two-step OptionValueConverter >> - Add ValueConverterFunction >> - Change signature of OptionValueConverter. >> - Validator, OptionValueConverter: better javadoc >> - Change signature of ValueConverter::convert() >> - ... and 2 more: https://git.openjdk.org/jdk/compare/46375e6f...5c47219b > > src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties > line 94: > >> 92: error.properties-parameter-not-path=The value "{0}" provided for >> property "{1}" in "{2}" file is not a valid path >> 93: error.properties-parameter-not-file=The value "{0}" provided for >> property "{1}" in "{2}" file is not a file >> 94: error.properties-parameter-not-directory=The value "{0}" provided for >> property "{1}" in "{2}" file is not a directory > > `file is not a directory` -> `is not a directory`? The "file" refers to the input property file. E.g.: for `jpackage --add-launcher=foo.properties` command line, if the `foo.properties` file contains a property `input` with the value of "not-a-directory" that should be a directory, then the error message will be: Error: The value "not-a-directory" provided for property "input" in "foo.properties" file is not a directory The wording is consistent with the similar error messages. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29194#discussion_r2692403490
