On Wed, 14 Jan 2026 16:24:23 GMT, Alexey Semenyuk <[email protected]> wrote:

>> Change how the values of the "--app-content", "--input", and 
>> "--mac-dmg-content" options are handled. Traverse the input directories 
>> during the configuration phase, before jpackage creates any output, rather 
>> than during the packaging phase.
>> 
>> This change required rework of the cli package to support converting values 
>> of any type to any type (`T -> T2`). Previously, it supported only String 
>> converters (`String -> T`).
>
> Alexey Semenyuk has refreshed the contents of this pull request, and previous 
> commits have been removed. The incremental views will show differences 
> compared to the previous content of the PR. The pull request contains 12 new 
> commits since the last revision:
> 
>  - Update copyright year
>  - InOutPathTest: remove tests cases for non-existent paths specified for 
> --app-content and --mac-dmg-content options; AppContentTest: add a test case 
> for --app-content set to the output app image
>  - FileUtils: remove redundant functionality
>  - Add and integrate RootedPath
>  - AppContentTest: don't verify app image if jpackage is expected to fail
>  - Support two-step OptionValueConverter
>  - Add ValueConverterFunction
>  - Change signature of OptionValueConverter.
>  - Validator, OptionValueConverter: better javadoc
>  - Change signature of ValueConverter::convert()
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/46375e6f...5c47219b

Marked as reviewed by almatvee (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/29194#pullrequestreview-3672479454

Reply via email to